Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connor Martinelli HW Solutions #8

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Connor Martinelli HW Solutions #8

wants to merge 8 commits into from

Conversation

conmart
Copy link

@conmart conmart commented Sep 13, 2017

Definitely not the cleanest code but it gets the job done

spragala
spragala reviewed Sep 13, 2017
View reviewed changes
Copy link

@spragala spragala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job.

username.rb
def format_name(first, last)
nil
if (first == "" || last == "")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, but Ruby has lots of fun methods. Check out .empty?

username.rb
end


def user_type_prefix (num = 0)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

username.rb
def format_year
nil

$list_of_usernames = []
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spragala spragala spragala left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conmart @spragala